February 6, 201016 yr Hi, Thank you to everyone who has helped me over the last few weeks. Your help has been invaluable. I have put the website live, but am still working through a few little niggles. However, thought it might be useful to post on here for any feedback, issues that you find, and also because I'm pretty chuffed. This is my first site using HTML and CSS. The site is here
February 6, 201016 yr bugs (tested in FF only) ... http://www.loanresolutions.co.uk/unenforceablecreditagreements.html#top - "back to the top" does not return to top (seems to be common on a few pages - missing anchor?) http://www.loanresolutions.co.uk/ukcommercialpropertytaxallowance.html - corrupted at top RHS ( shows some sort of path ref="index.html" title="Home">Home ) Also fails validation - http://validator.w3.org/check?uri=http%3A%2F%2Fwww.loanresolutions.co.uk%2Findex.html&charset=%28detect+automatically%29&doctype=Inline&group=0 Apart from that, a really nice site - well done
February 6, 201016 yr I never looked at the code, but i'm sure it's more than acceptable. You seem quite maticulous in your posting and the site looks polished. Well done you.
February 7, 201016 yr site looks great! i'm just starting out, can i ask, how much did you charge your client for that site? I'm wondering because i would like to go freelance sometime in the near future
February 7, 201016 yr Author site looks great! i'm just starting out, can i ask, how much did you charge your client for that site? I'm wondering because i would like to go freelance sometime in the near future No charge because I used it as a learning exercise.
February 7, 201016 yr looks really nice wonder why you saved the main banner background as a gif and not a jpeg? you have some banding in the gradients (it's not smooth) and a jpeg would be smaller filesize. are you using photoshop or... ? missing some alt text of images?! some space between paragraphs would look nicer - splitting the text into smaller chunks your h4 looks the same size as your h3 - it should be smaller no favicon - you have a very nice logo there and the square would make an ideal favicon. you can use something like this to help http://tools.dynamicdrive.com/favicon/ good job though edit: ps it's an unusual colour scheme but it really works and you have a few errors in your code if you check with the w3c validator
February 8, 201016 yr Well done mrsminkie - that's an excellent start! If I can be pickie: CSS... /* remember to define focus styles! */ :focus {outline: 0;} This is a big accessibility no no. Removing the outline totally removes the ability to navigate the site by keyboard. If you don't want the outline (and there's no reason why you don't need it) then style :focus with a background colour. Also add a background colour to the body tag
February 8, 201016 yr Niggles be damned! That's a bloody excellent design, especially for popping your design cherry!
February 8, 201016 yr Author looks really nice wonder why you saved the main banner background as a gif and not a jpeg? you have some banding in the gradients (it's not smooth) and a jpeg would be smaller filesize. are you using photoshop or... ? missing some alt text of images?! some space between paragraphs would look nicer - splitting the text into smaller chunks your h4 looks the same size as your h3 - it should be smaller no favicon - you have a very nice logo there and the square would make an ideal favicon. you can use something like this to help http://tools.dynamicdrive.com/favicon/ good job though edit: ps it's an unusual colour scheme but it really works and you have a few errors in your code if you check with the w3c validator Hi Dave, Thank you for your feedback. I've removed the outline part in my CSS - it was a reset offered by someone on here, but I've removed some parts now. Also, I do have a favicon, but it doesn't always show. I don't know why. I need to go through and sorted my headers out as I've skipped h2 so I need to 'promote' my h3's to h2.... I did run it through the validator and I didn't quite understand the results. It is something that I am working through though. I have also re-saved the banner image in jpg and it does look much better. No idea why I used gif...? Think it was just automatic as I've saved a lot of my other images in gif. I thought they were better to use than jpeg?
February 8, 201016 yr Author looks really nice wonder why you saved the main banner background as a gif and not a jpeg? you have some banding in the gradients (it's not smooth) and a jpeg would be smaller filesize. are you using photoshop or... ? missing some alt text of images?! some space between paragraphs would look nicer - splitting the text into smaller chunks your h4 looks the same size as your h3 - it should be smaller no favicon - you have a very nice logo there and the square would make an ideal favicon. you can use something like this to help http://tools.dynamicdrive.com/favicon/ good job though edit: ps it's an unusual colour scheme but it really works and you have a few errors in your code if you check with the w3c validator
February 8, 201016 yr This is a warning, therefore it's not too important to change it, however, if you want to make sure it validates correctly it's probably wise to either remove the / from <link href="stylesheet.css" rel="stylesheet" type="text/css" /> or to change your doctype to strict. In your source you have a <style type="text/css"></style> which isn't being used. If you have any styles for a page they should be in an external style sheet (.css file) (will post more in a sec, at work ;p)
February 8, 201016 yr Author This is a warning, therefore it's not too important to change it, however, if you want to make sure it validates correctly it's probably wise to either remove the / from <link href="stylesheet.css" rel="stylesheet" type="text/css" /> or to change your doctype to strict. In your source you have a <style type="text/css"></style> which isn't being used. If you have any styles for a page they should be in an external style sheet (.css file) (will post more in a sec, at work ;p) Any idea where the '/' came from and why it's causing such an issue? The <style type....> I think was left in there as I did have some inline styles but I removed them. I will remove it from the 'offending' pages. Cheers for your help.
Create an account or sign in to comment