March 8, 200917 yr Ok so hoping it's not too bad in comparison with some I have seen on here, because standard seems to be very high on this forum Known issues: - Coding is... well just don't look at it or your eyes will bleed - It's on my to-do list - Needs more colour - any suggestions? I like subtlety - Internet Explorer doesn't like the adverts - Hm? Demon CSS Thanks for looking
March 9, 200917 yr Ok so hoping it's not too bad in comparison with some I have seen on here, because standard seems to be very high on this forum Known issues: - Coding is... well just don't look at it or your eyes will bleed - It's on my to-do list - Needs more colour - any suggestions? I like subtlety - Internet Explorer doesn't like the adverts - Hm? Demon CSS Thanks for looking I would agree that it could do with a bit more colour, just to give the page a bit more impact. Another thing I noticed is that you seem to have a lot of id and classes that are not really required. If the site is to promote the use of CSS over tables all the power to you - but the beauty of CSS is in the fact that you can keep your code really clean and semantic. (Not being negative here I hope you understand, just trying to help!) I will pick a couple of examples to show what I mean... On the homepage you have the following: <div id="news"> <h2 id="date_text">8th March 2009</h2> Setting your font size to 16. To make this more semantic and to reduce the code you would be better using: <div id="news"> <h2>8th March 2009</h2> and in your stylesheet put: #news h2 {font-size:16px;} On your templates page you seem to be attaching an id on to each heading tag? For a start there should only be one element on the page with an ID, for multiple elements you should use a class - but again there is no need... Instead of: <div class="addcontent"> <h2 id="h2">Simple Box Centered Template</h2> To set the font-size to 16px, you would be better... <div class="addcontent"> <h2>Simple Box Centred Template</h2> within your stylesheet: .addcontent h2 {font-size:16px;} Or if your whole site sets 16px as a standard for h2 tags, just put: h2 {font-size:16px;} ...in the stylesheet and be done with it. The only reason I point this out is that if people are going to come to your site for CSS templates they will probably have a reasonable understanding of this kind of stuff already and you want get a good reputation from the start. I honestly wish you the best of luck with the site as it is more promotion for ditching tables, but you need to clean up your own CSS out before passing any on to others. If I can offer any advice or help in anyway feel free to PM and I will help where I can.
March 9, 200917 yr Instead of putting "Best viewed in Firefox 3" in the footer put this so it will only show in IE: <!--[if IE]><p>Site best viewed in Firefox 3</p><![endif]--> Your daily pro coding tips by Meshach.
March 9, 200917 yr Instead of putting "Best viewed in Firefox 3" in the footer put this so it will only show in IE: <!--[if IE]><p>Site best viewed in Firefox 3</p><![endif]--> Your daily pro coding tips by Meshach. or dont put "Best viewed in Firefox 3" at all!
March 9, 200917 yr Author Thanks Gordon - I've still got a lot to learn and that's a great help. You're right about the whole code needing to be tidy Any suggestions on a bit of colour to compliment it all?
March 9, 200917 yr Thanks Gordon - I've still got a lot to learn and that's a great help. You're right about the whole code needing to be tidy Any suggestions on a bit of colour to compliment it all? I'm glad you took it that way! Colours really are down to what you feel suits the site and it's audience best. If you are struggling to come up with a colour scheme I would recommend you have a dig through ColourLovers. You can put your background colour in and see what colour schemes other people have come up with - really handy site. I would take heed of the comments above also, I too am not a fan of 'best viewed in' comments. To be honest if you aim for strict validation and clean CSS there is no real reason to stipulate a best browser. However you don't want to get me started on the 'should we drop support for IE6' argument as you'll never shut me up! Take it easy...
March 9, 200917 yr Author I'll take a look at colour lovers and try and sort something out, I know what you mean about the 'best viewed in' thing. Cheers for the advice everyone!
March 9, 200917 yr Author Anyone else got any ideas on colour? I'm really not sure, I've changed the body text to black and it looks better imo...
March 9, 200917 yr Author i love design did you do the little monster/devil yourself? personally i like the colour Thanks The little demon thing is from a stock image site, thought it would give the design a bit of character
Create an account or sign in to comment