So quite a while ago I asked for feedback on some initial designs for my university project:

 

http://www.webdesignerforum.co.uk/index.php?showtopic=3197

 

Well the project has come a long way and is now online and going through testing.

 

I would really appreciate some feedback from webbys regarding design, functionality, problems and ultimately any suggestions to improve the site.

 

Anyway the site is about creating wishlists from any website so here is the link:

 

http://www.nomorenotebooks.com

 

I look forward to the feedback

 

I think design-wise this is a very professional looking site. I would suggest taking at look at your code though - W3C finds 226 errors on your home page.

Not much else to say really - it's not the kind of site I would normally use, but I can't see anything about the design to improve really. I like it a lot.

thanks for responding notbanksy,

 

regarding the errors, sadly the all relate to me using <img onError= which I need to do really.

 

Anyone have a compliant solution for this?

 

thanks

thanks for responding notbanksy,

 

regarding the errors, sadly the all relate to me using <img onError= which I need to do really.

 

Anyone have a compliant solution for this?

 

thanks

 

What is the reason behind the need to use onError? If we know what functionality you require, we might be able to suggest another method to achieve it.

 

As for your website: it is a nice design, with a good grid system and professional looking graphics. My only comments are about the validation, and also that you have a lot of inline javascript, which isn't good practice. You should be putting your Javascript in external files.

What is the reason behind the need to use onError? If we know what functionality you require, we might be able to suggest another method to achieve it.

 

As for your website: it is a nice design, with a good grid system and professional looking graphics. My only comments are about the validation, and also that you have a lot of inline javascript, which isn't good practice. You should be putting your Javascript in external files.

 

Thanks, Rob

 

I just realised I was using it in a stupid way, have changed it slightly and now have eliminated the errors down to one but not sure how to make that compliant (ignoring the id error which I will change to class soon)

 

http://validator.w3.org/check?uri=http%3A%...roup=0&st=1

 

Also can you please let me know where I have included inline JS unnecessarily please, i'm not sure where you mean?

 

thanks

I'm not sure which error you mean — one of them is about a & character which you should be using & instead of, in the code.

 

As for the inline Javascript, it's in amongst your home page at various places throughout the source code. You have random <script>…</script> chunks which should ideally be in external files for easier maintenance, etc.

I'm not sure which error you mean — one of them is about a & character which you should be using & instead of, in the code.

 

As for the inline Javascript, it's in amongst your home page at various places throughout the source code. You have random <script>…</script> chunks which should ideally be in external files for easier maintenance, etc.

 

Regarding the amp character, that comes up randomly based on which products are loaded, it is down to whatever the member who added the product named it. I could set up a script that changes all & to amp when someone adds something new but hadnt realised it was necessary.

 

Also I am looking at the source code and the only JS that doesnt link to an external file is google adsense and analytics scripts. Should I be putting these in external JS files?

Hmm, it's gone now!

 

You do have alot of inline javascript in the form of onmouseover="ddrivetip('user: jgs526')" onmouseout="hideddrivetip()", for example. These should really be in external Javascript files and manipulated using DOM, but it isn't necessary.

 

In my searches I did notice you have a <script> tag linking to tooltip.js, which should be in your head — but this is me being picky now!

 

Just fix up the validation and you're golden, good job!

Hmm, it's gone now!

 

You do have alot of inline javascript in the form of onmouseover="ddrivetip('user: jgs526')" onmouseout="hideddrivetip()", for example. These should really be in external Javascript files and manipulated using DOM, but it isn't necessary.

 

In my searches I did notice you have a <script> tag linking to tooltip.js, which should be in your head — but this is me being picky now!

 

Just fix up the validation and you're golden, good job!

 

thanks rob, I would ideally have that in the head too, but when stylesheets are turned off it adds an image to the top of the page which is the wrong place so I sort of have to have it in the body so the document flows for those with SS's off. annoying but fair I think.

 

Don't think I can validate the onerror thing truely though, cant seem to find an answer to it being a complient tag.

i like it very nice