Ok past couple of weeks been learning xhtml and css and with the help of this forum i have learn quite abit

 

so here is my first site

 

http://www.joshgraphics.co.uk

 

few things i still need to add, waiting for april competition so can add to portfolio

 

but thought would put it out there as i was excited, im sure you remember putting your first site online and thinking it was the dogs ******.

Edited April 1, 201115 yr by JoshGraphics

You may want to edit the code a little...

 

1. You need to add the closing quote mark on <?xml version="1.0" encoding="utf-8?> - should be <?xml version="1.0" encoding="utf-8"?>

 

2. You have no description metatag - always a good idea.

 

3. Use an external stylesheet and link to it in the <head> section - makes for easier site wide changes later on.

 

4. You currently have 2 closing </head> tags & 2 <body> tags.

 

5. You have an additional <style></style> within the body tags.

 

6. You are using closing p tags </p> but not any opening tag <p>

 

7. You are not closing the <a href> tags on those BIG Twitter/Facebook links - </a>

 

Hope this helps.

ok made a few changes (will make them live soon)

 

6. You are using closing p tags </p> but not any opening tag <p>

 

according to linda.com its cool to use <p /> instad of <p></p>

 

thanks for the feed

Pretty good for your first website. That background looks familiar.

 

Couple things I would change. Reduce the size of the social icons as well as the logo. They are much too massive. Your navigation could use more style. They are pretty basic right now. The hover color for it is also a little too light.

 

I would left align your form. Having it center is a little weird.

 

Adding to what was said about your code, don't use the center tag. It is depreciated. And when you use CSS3, make sure you use all browser vender prefixes. Im viewing your site on Chrome, and I didn't get your CSS3 you added for Firefox. I try to make a habit to include it for webkit, mozilla, opera, and ms, even if the current browser doesn't support it just to future proof it (if they decide to add support later, I don't need to go and change code).

lmao i can be totally truthfull and say i have only just sin your website this second

 

Edit: thanks for the feed willupdate soon

Edited April 1, 201115 yr by JoshGraphics

according to linda.com its cool to use <p /> instad of <p></p>

 

According to my knowledge (and depending on the doctype), it is ok to omit the closing tag, but never the open tag. For example:

 

<p>this is a sentence.
<p>this is another.

 

Having only the closing tag doesn't make sense because the browser doesn't know where to start the paragraph, where as just omitting the ending tag the browser just assumes the next tag is where the paragraph ends.

 

In best practice you should always include both the opening and closing.

lmao i can be totally truthfull and say i have only just sin your website this second

 

Edit: thanks for the feed willupdate soon

 

I wasn't accusing you of stealing the background. It is a common pattern. Just funny to see it on another site.

I wasn't accusing you of stealing the background. It is a common pattern. Just funny to see it on another site.

Lots of screen real estate wasted with the narrow content area in the middle, But pretty good for a first attempt

true, i think im gonna add sidebar with twitter feed update and maybe have adverts